Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Control Builder,ChangesFileBuilder,pom.xml,DebMaker #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Turbocyb0rg
Copy link

adding properties for the source and target 1.8 to 17 resolved the warning

import java.nio.charset.StandardCharsets; in ControlBuilder

few of the TODO's and FIXNeeded parts

NullOutputStream.NULL_OUTPUT_STREAM is deprecated changed to NullOutputStream.INSTANCE

because NullOutputStream have a field named INSTANCE, resolved the warning. in ChangesFileBuilder and ControlBuilder

String content = IOUtils.toString(in); changed to String content = IOUtils.toString(in, StandardCharsets.UTF_8); in ControlBuilder

this.signDigest = signDigest; changed to this.signDigest = digest;

changes to LsMapper private int convertModeFromString( final String mode )

changes in isSubmodules(), whether the current Maven project is a submodule or not

check if the entry name ends with a symbolic link extension (.symlink) i.e., if (src.getName().endsWith(".symlink"))

…rning

import java.nio.charset.StandardCharsets; in ControlBuilder

few of the TODO's and FIXNeeded parts

NullOutputStream.NULL_OUTPUT_STREAM is deprecated changed to NullOutputStream.INSTANCE

because NullOutputStream have a field named INSTANCE, resolved the warning. in ChangesFileBuilder and ControlBuilder

String content = IOUtils.toString(in); changed to String content = IOUtils.toString(in, StandardCharsets.UTF_8); in ControlBuilder

this.signDigest = signDigest; changed to this.signDigest = digest;

changes to LsMapper private int convertModeFromString( final String mode )

changes in isSubmodules(), whether the current Maven project is a submodule or not

check if the entry name ends with a symbolic link extension (.symlink) i.e., if (src.getName().endsWith(".symlink"))
@Turbocyb0rg Turbocyb0rg changed the title **Exploring** Update Control Builder,ChangesFileBuilder,pom.xml,DebMaker Mar 23, 2024
@tcurdt
Copy link
Owner

tcurdt commented Apr 9, 2024

Thanks for the contribution - but it seems like this has build issues.

It would also be much better to create smaller and more focused PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants