Prevent min / max macro expansion on Windows #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows some modules might includes the windows.h header, which then defines macros for min and max, among other macros. The uniform_random_bit_generator_concept is susceptible to this problem and fails to compile.
The proper way of handling this issue is to prevent the macro expansion by enclosing the macro names in parenthesis.
The other known workaround is to define the NOMINMAX macro (but this is user-configurable and not suitable for libraries).