Temporarily remove export defer * as x from "x"
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\tc39#30 and tc39#31, that implement more general "optional/deferred re-exports" with tree-shaking capabilities, give two different meaning to `export defer * as x from "x"`: - in tc39#30, `export defer * as x from "x"` unconditionally loads `"x"`, and defers it's execution until when the namespace is used - in tc39#31, it only loads `x` if some module is actually importing `{ x }` from this one, and then defers its execution Due to this difference, for now it's better to remove `export defer *` until its semantics are settlet, together with the other `export defer`/ `export optional` cases. I will include a revert for this commit in those two PRs.
acutmore
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30 and #31, that implement more general "optional/deferred re-exports" with tree-shaking capabilities, give two different meaning to
export defer * as x from "x":export defer * as x from "x"unconditionally loads"x", and defers it's execution until when the namespace is usedxif some module is actually importing{ x }from this one, and then defers its executionDue to this difference, for now it's better to remove
export defer *until its semantics are settlet, together with the otherexport defer/export optionalcases. I will include a revert for this commit in those two PRs.