This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Transformation of TLD content and Properties file relocation #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits to fix the 2 issues:
Properties files are not transformed #121
Transform TLD #125
The TLD action is a simple extension of the XMLActionImpl. The XML master properties file needs to contain *.tld=
I didn't touch at the Jakarta transformer XML default rule files.
The Properties action relocates the file according to the package renaming rules.
Both actions have been added to the jar container action only.
I have been greatly inspired by the existing unit tests to add 2 new unit tests.