fix: properly parse empty messages in options (protobufjs#1429)

* Properly parse empty messages in options * Add missing semicolon in test
taylorcode · Oct 16, 2020 · ffc9400 · ffc9400
1 parent c76496e
commit ffc9400
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/parse.js b/src/parse.js
@@ -555,7 +555,7 @@ function parse(source, root, options) {
 
     function parseOptionValue(parent, name) {
         if (skip("{", true)) { // { a: "foo" b { c: "bar" } }
-            do {
+            while (!skip("}", true)) {
                 /* istanbul ignore if */
                 if (!nameRe.test(token = next()))
                     throw illegal(token, "name");
@@ -570,7 +570,7 @@ function parse(source, root, options) {
                         setOption(parent, name + "." + token, readValue(true));
                 }
                 skip(",", true);
-            } while (!skip("}", true));
+            }
         } else
             setOption(parent, name, readValue(true));
         // Does not enforce a delimiter to be universal

diff --git a/tests/data/uncommon.proto b/tests/data/uncommon.proto
@@ -31,6 +31,8 @@ message Test2 {
 
     map<uint64,Test> longmap = 10;
 
+    int32 optionTest = 11 [(my_options) = { a: "foo" b {} }];
+
     /** pre */
     oneof kind;
     oneof kind2; /// post