Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(core/shell): speedup Command.execute & fix extra new lines (#9706)" #9792

Merged
merged 2 commits into from
May 15, 2024
Merged

Revert "fix(core/shell): speedup Command.execute & fix extra new lines (#9706)" #9792

merged 2 commits into from
May 15, 2024

Conversation

amrbashir
Copy link
Member

This reverts commit 7f885bd.

@amrbashir amrbashir requested a review from a team as a code owner May 15, 2024 15:23
@amrbashir amrbashir linked an issue May 15, 2024 that may be closed by this pull request
[bug] unknown variant executeAndReturn, expected one of execute, stdinWrite, killChild, open #9786
Closed
@amrbashir amrbashir requested a review from FabianLars May 15, 2024 15:49
FabianLars
FabianLars approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(honestly don't really care about minor vs patch here)

@amrbashir amrbashir merged commit 3b69c13 into 1.x May 15, 2024
29 checks passed
@amrbashir amrbashir deleted the revert-9706 branch May 15, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] unknown variant executeAndReturn, expected one of execute, stdinWrite, killChild, open
2 participants
@amrbashir @FabianLars