Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos/dialog): avoid setting empty default_path #9784

Merged
merged 1 commit into from
May 15, 2024

Conversation

amrbashir
Copy link
Member

closes #7566

ref: #4065
ref: #4028
ref: #9762

@amrbashir amrbashir requested a review from a team as a code owner May 15, 2024 00:50
@FabianLars
Copy link
Member

Are strings/paths containing only whitespace a concern too? (Not as common as empty paths ig but worth to double check while we're at it maybe)

@amrbashir
Copy link
Member Author

I am reluctant to adding this fix and lean towards making it the developer responsibility to pass defaultPath: null instead of empty but seeing that some tauri users fall in this crash quite often, we should add this fix but other than this, it shouldn't be our problem and they should handle it themselves.

@FabianLars
Copy link
Member

ok

@amrbashir amrbashir merged commit 704260b into 1.x May 15, 2024
24 checks passed
@amrbashir amrbashir deleted the fix/macos/dialog-default-path branch May 15, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants