Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): temp permission file names on windows #9477

Merged

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Apr 16, 2024

Probably fixes #9045

We're currently using tauri: prefix on temporary permission file names for core plugins, but : is a reserved character on Windows file system, this PR replaces tauri: prefix with tauri-

https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#:~:text=%3E%20(greater%20than)-,%3A%20(colon),-%22%20(double%20quote)

@Legend-Master Legend-Master requested a review from a team as a code owner April 16, 2024 06:05
lucasfernog
lucasfernog previously approved these changes Apr 21, 2024
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@lucasfernog lucasfernog merged commit a1e0e26 into tauri-apps:dev Apr 22, 2024
23 checks passed
@Legend-Master Legend-Master deleted the fix-permission-temp-file-path branch April 22, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Tauri v2.0.0-beta failed to build on Windows
2 participants