fix(core/updater): pass /NS to nsis installer to disable creating shortcuts on updates
#9413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hortcuts on updates closes #9395
amrbashir
changed the title
/NS to nsis installer to disable creating shortcuts on updates
lucasfernog
reviewed
Apr 21, 2024
lucasfernog
requested changes
Apr 21, 2024
| pub fn nsis_args(&self) -> &'static [&'static str] { | ||
| match self { | ||
| Self::Passive => &["/P", "/R"], | ||
| Self::Quiet => &["/S", "/R"], | ||
| Self::Passive => &["/P", "/R", "/NS"], |
There was a problem hiding this comment.
since this isn't related to the install mode, shouldn't it be set in core/tauri/src/updater/core.rs instead?
There was a problem hiding this comment.
that could be argued for /R as well, but both should stay here because it is called WindowsUpdateInstallMode, i.e. related to updater and these flags are in scope of the updater.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9395