fix(cli): fix migration from globalShortcut to global-shortcut #9262
+75
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-global-shortcut-and-skip-app.md
Ignoring all core modules allows for the command to be re-run multiple times without strange mutations.
Running `tauri migrate` more than once would wipe previously migrated capabilities.
…ti-run-migrate-and-package-names.md
lucasfernog
reviewed
Mar 27, 2024
| )?; | ||
| } else { | ||
| log::info!( | ||
| "Skipping capabilities migration; migrated capabilities found in {}", |
There was a problem hiding this comment.
should we also print the migrated capability json here? so the user can compare both files (or maybe write to migrates.json.tmp)
There was a problem hiding this comment.
The established pattern so far has been to print any manual changes. Rather than a temporary file that the user is expected to act on, would it be better to check if migrated.permissions is empty and, if not, make another file without the *:defaults?
Vector allocation and cloning is an expensive operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in Discord: https://discord.com/channels/616186924390023171/731495028677148753/1221393137659023390.