feat(api): Add append option to writeFile apis
#7636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianLars
commented
Aug 16, 2023
FabianLars
commented
Aug 16, 2023
| * | ||
| * @since 1.5.0 | ||
| */ | ||
| append?: boolean | ||
| // note that adding fields here needs a change in the writeBinaryFile check |
There was a problem hiding this comment.
didn't understand what this means
|
even tokio is betraying us now, holy shit 😂 |
amrbashir
previously approved these changes
Aug 16, 2023
amrbashir
reviewed
Aug 16, 2023
|
and clippy failed too |
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
approved these changes
Aug 16, 2023
amrbashir
changed the title
append option to writeFile apis.append option to writeFile apis
|
Lets fix the tokio issue in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7092
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information