Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/plugin): add register_uri_scheme_protocol, closes #7330 #7350

Merged
merged 6 commits into from
Jul 12, 2023
Merged

feat(core/plugin): add register_uri_scheme_protocol, closes #7330 #7350

merged 6 commits into from
Jul 12, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 4, 2023 •
edited

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner July 4, 2023 12:35
@amrbashir amrbashir linked an issue Jul 4, 2023 that may be closed by this pull request
[feat] Allow plugins to configure custom protocol scheme #7330
Closed
wusyong
wusyong previously approved these changes Jul 10, 2023
View reviewed changes
@lucasfernog lucasfernog merged commit fdaee9a into 1.x Jul 12, 2023
26 checks passed
@lucasfernog lucasfernog deleted the feat/plugin-custom-protocol branch July 12, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@wusyong wusyong wusyong left review comments

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Allow plugins to configure custom protocol scheme
3 participants
@amrbashir @wusyong @lucasfernog