Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Disable version check, fixes #7273 #7277

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

FabianLars
Copy link
Member

I can also confirm that this improves the cli behavior in powershell for me (still not perfect but better)!

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, i guess so but it's worth it imo.
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

#7273
https://discord.com/channels/616186924390023171/986184094050316358/1120944919410909184
https://discord.com/channels/616186924390023171/986184168998330371/1119297196282630144

@FabianLars FabianLars requested a review from a team as a code owner June 21, 2023 10:45
@wusyong wusyong merged commit dad4f54 into 1.x Jun 21, 2023
11 checks passed
@amrbashir amrbashir deleted the cli-version-check branch August 22, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

None yet

3 participants