Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix nsis updater unable to launch installers requiring elevation, closes #7184 #7185

Merged
merged 5 commits into from
Jun 19, 2023

Conversation

Raphiiko
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This PR should fix the issue posted in #7184. I am not quite sure if this is the correct solution, but it seems to fix the problem for me.

Of course this does not solve the problem for existing builds, but I don't see a way for that to be fixed. Users will have to update once by launching the old version as administrator in order to update, or by reinstalling the new version.

@Raphiiko Raphiiko requested a review from a team as a code owner June 12, 2023 16:43
@Raphiiko Raphiiko marked this pull request as draft June 12, 2023 23:55
@Raphiiko
Copy link
Contributor Author

Raphiiko commented Jun 12, 2023

I am converting this back to draft. It seems to fix the issue in debug mode, but when running in release mode it seems unreliable. I'm not sure why yet.

Edit: nvm, I believe this was unrelated.

@Raphiiko Raphiiko marked this pull request as ready for review June 13, 2023 09:55
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for you contribution

core/tauri/src/updater/core.rs Outdated Show resolved Hide resolved
@amrbashir amrbashir changed the base branch from dev to 1.x June 19, 2023 14:12
@amrbashir amrbashir changed the title fix(core): Fix updater not being able to launch installers requiring elevation (fix: #7184) fix(core): fix nsis updater unable to launch installers requiring elevation, closes #7184 Jun 19, 2023
@amrbashir amrbashir merged commit 1a3dcdb into tauri-apps:1.x Jun 19, 2023
18 checks passed
amrbashir added a commit to tauri-apps/plugins-workspace that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

None yet

2 participants