Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add key.properties to android gitignore #6811

Merged
merged 1 commit into from Apr 27, 2023
Merged

feat: add key.properties to android gitignore #6811

merged 1 commit into from Apr 27, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Apr 27, 2023 •
edited

local.properties file may get overridden by gradle to store sdk.dir

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner April 27, 2023 13:07
@amrbashir amrbashir merged commit 19cd0e4 into next Apr 27, 2023
13 of 14 checks passed
@amrbashir amrbashir deleted the feat/cli/update-android-gitignore branch April 27, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @wusyong