Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): use snake_case fallback of app_name #6788

Merged
merged 1 commit into from Apr 25, 2023
Merged

fix(cli): use snake_case fallback of app_name #6788

merged 1 commit into from Apr 25, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Apr 24, 2023 •
edited

closes #6787

fix regression introduced in 2b22f64

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner April 24, 2023 19:39
@lucasfernog lucasfernog merged commit 124d5c5 into next Apr 25, 2023
13 of 14 checks passed
@lucasfernog lucasfernog deleted the fix/cli/lib_name branch April 25, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @lucasfernog