Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improvements to support hyphens in crate name #5989

Merged
merged 11 commits into from
Jan 6, 2023
Merged

feat: improvements to support hyphens in crate name #5989

merged 11 commits into from
Jan 6, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jan 5, 2023 •
edited

Needs tauri-apps/cargo-mobile2#73

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested review from a team as code owners January 5, 2023 17:58
@amrbashir amrbashir changed the base branch from dev to next January 5, 2023 17:59
@amrbashir amrbashir mentioned this pull request Jan 6, 2023
Merged
19 tasks
@lucasfernog lucasfernog merged commit 50f6dd8 into next Jan 6, 2023
@lucasfernog lucasfernog deleted the hyphens branch January 6, 2023 17:31
@amrbashir amrbashir mentioned this pull request Jan 15, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @lucasfernog