Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): detect SolidJS and SolidStart #5758

Merged
merged 4 commits into from Dec 8, 2022
Merged

feat(cli): detect SolidJS and SolidStart #5758

merged 4 commits into from Dec 8, 2022

Conversation

AR10Dev
Copy link
Contributor

@AR10Dev AR10Dev commented Dec 3, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@AR10Dev AR10Dev requested a review from a team as a code owner December 3, 2022 13:17
lucasfernog
lucasfernog requested changes Dec 7, 2022
View reviewed changes
tooling/cli/src/helpers/framework.rs Outdated Show resolved Hide resolved
tooling/cli/src/helpers/framework.rs Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 9e7ce0a into tauri-apps:dev Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AR10Dev @lucasfernog