Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
When using the
invoke
function asynchronously to run a Rust function and return a value that can be serialized, the serialized value is serialized a second time, uselessly. This is because of a useless conversion in the functionhooks::respond_async_serialized
: The task returns aResult<JsonValue, InvokeError>
that is converted into aInvokeResponse
by the call tointo()
. AnInvokeResponse
is in practise exactly equal to aResult<JsonValue, InvokeError>
so the conversion should be immediate. However, the call tointo()
use the implFrom<Result<T, InvokeError>> for InvokeResponse
(whereT: Serialize
), which serialize theJsonValue
into aJsonValue
(and that is not instantaneous).