Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add title getter on window, closes #5023 #5515

Merged
merged 8 commits into from Dec 13, 2022
Merged

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Oct 30, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner October 30, 2022 18:20
lucasfernog
lucasfernog previously approved these changes Dec 13, 2022
@lucasfernog lucasfernog merged commit 233e43b into dev Dec 13, 2022
@lucasfernog lucasfernog deleted the title-getter branch December 13, 2022 03:59
@elibroftw
Copy link

elibroftw commented Dec 23, 2022

When will this be in production? I'm working on a custom titlebar and this is the second last piece of perfection.
image
Also how do I disable the native title bar? I have decorations set to false.

@elibroftw
Copy link

elibroftw commented May 6, 2023

image

appWindow.title().then(title => {
      if (windowTitle !== title) setWindowTitle(title);
    });

image

@elibroftw
Copy link

image

@elibroftw
Copy link

nvm just have to upgrade cargo most likely,

@elibroftw
Copy link

I updated cargo.toml, and still same error. Does it work for you guys?

@elibroftw
Copy link

elibroftw commented May 6, 2023

Seems like the other plugins like tauri-plugin-window-state and tauri-plugin-store and tauri-plugin-single-instance depend on 1.2.5?

Had to set tauri = { version = "1.3",

@FabianLars
Copy link
Member

Seems like the other plugins like tauri-plugin-window-state and tauri-plugin-store and tauri-plugin-single-instance depend on 1.2.5?

Nope, they only specify "1", so if we ignore the fact that some plugins use apis introduced in 1.1 and 1.2 the plugins don't care about the minor version and a simple cargo update is supposed to update it (adding 1.3 in your cargo.toml file is basically the same in this context since it tells cargo to upgrade to at least 1.3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants