Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): validate productName in config, closes #5233 #5262

Merged
merged 6 commits into from Sep 28, 2022
Merged

fix(cli): validate productName in config, closes #5233 #5262

merged 6 commits into from Sep 28, 2022

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 22, 2022 •
edited

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 22, 2022 12:12
@amrbashir amrbashir mentioned this pull request Sep 22, 2022
Closed
@amrbashir amrbashir changed the title fix(cli): fix building when productanme is namespaced, closes #5233 fix(cli): validate productName in config, closes #5233 Sep 23, 2022
@lucasfernog lucasfernog merged commit b9316a6 into dev Sep 28, 2022
@lucasfernog lucasfernog deleted the fix-namespaced-productname branch September 28, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @lucasfernog