Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): set correct mimetype for asset protocol streams, closes #5203 #5210

Merged
merged 9 commits into from Sep 30, 2022
Merged

fix(core): set correct mimetype for asset protocol streams, closes #5203 #5210

merged 9 commits into from Sep 30, 2022

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 16, 2022 13:56
@amrbashir amrbashir changed the title fix(core): set correct mimetype for asset protocol streames, closes #5203 fix(core): set correct mimetype for asset protocol streams, closes #5203 Sep 16, 2022
lucasfernog
lucasfernog requested changes Sep 16, 2022
View reviewed changes
core/tauri/src/manager.rs Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 39443b4 into dev Sep 30, 2022
@lucasfernog lucasfernog deleted the asset-mimetype branch September 30, 2022 18:38
lucasfernog pushed a commit that referenced this pull request Nov 3, 2022
@amrbashir @lucasfernog
Revert "fix(core): set correct mimetype for asset protocol streams, c…
2d9c2b4 
…loses #5203 (#5210)"

This reverts commit 39443b4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @lucasfernog