Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config schema generator #5193

Merged
merged 12 commits into from Oct 28, 2022
Merged

feat: config schema generator #5193

merged 12 commits into from Oct 28, 2022

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 14, 2022 23:46
@amrbashir
Copy link
Member Author

I am not sure why test-tauri-core fails with this PR when I made no changes to core

@lucasfernog
Copy link
Member

You did change it though, I think it's messing with the tauri-utils features. I'll take a look.

@lucasfernog
Copy link
Member

The biggest issue is adding the config-schema package to the workspace, which enables the isolation feature for the tauri-utils package even though it's not enabled for the other packages. I think we should find a different way to do this.

@amrbashir
Copy link
Member Author

amrbashir commented Sep 15, 2022

I could just remove it from the workspace, I mainly added it to the workspace so it can be autogenerated by the IDE's LSP when working with the config.

@lucasfernog lucasfernog requested a review from a team as a code owner October 20, 2022 14:13
@lucasfernog lucasfernog merged commit a178f95 into dev Oct 28, 2022
@lucasfernog lucasfernog deleted the config-schema-generator branch October 28, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants