Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Add exists function to the fs module. #5060

Merged
merged 6 commits into from Sep 15, 2022
Merged

feat(api): Add exists function to the fs module. #5060

merged 6 commits into from Sep 15, 2022

Conversation

FabianLars
Copy link
Member

Really just putting it up here so we don't forget it lol

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary - It's basically our most requested api.

@FabianLars FabianLars requested a review from a team as a code owner August 26, 2022 22:47
amrbashir
amrbashir requested changes Sep 5, 2022
View reviewed changes
tooling/api/src/fs.ts Show resolved Hide resolved
@FabianLars FabianLars mentioned this pull request Sep 7, 2022
Closed
amrbashir
amrbashir reviewed Sep 15, 2022
View reviewed changes
tooling/api/src/fs.ts Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 3c62dbc into dev Sep 15, 2022
@lucasfernog lucasfernog deleted the feat/exists-api branch September 15, 2022 14:28
lucasfernog pushed a commit that referenced this pull request Nov 8, 2022
@FabianLars @lucasfernog
Revert "feat(api): Add exists function to the fs module. (#5060)"
17e1eed 
This reverts commit 3c62dbc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir requested changes

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FabianLars @lucasfernog @amrbashir