Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tauri-build): validate sidecar name, closes #4780 closes #4823 #4814

Merged
merged 1 commit into from
Aug 2, 2022
Merged

feat(tauri-build): validate sidecar name, closes #4780 closes #4823 #4814

merged 1 commit into from
Aug 2, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner August 1, 2022 00:03
@lucasfernog lucasfernog mentioned this pull request Aug 2, 2022
Closed
@lucasfernog lucasfernog linked an issue Aug 2, 2022 that may be closed by this pull request
New window created on each trigger of sidecar #4823
Closed
@lucasfernog lucasfernog changed the title feat(tauri-build): validate sidecar name, closes #4780 feat(tauri-build): validate sidecar name, closes #4780 closes #4823 Aug 2, 2022
@lucasfernog lucasfernog merged commit 5cc1fd0 into dev Aug 2, 2022
@lucasfernog lucasfernog deleted the feat/validate-sidecar-name branch August 2, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New window created on each trigger of sidecar
1 participant
@lucasfernog