Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command support for specified character encoding, closes #4644 #4772

Merged
merged 2 commits into from Jul 27, 2022
Merged

Command support for specified character encoding, closes #4644 #4772

merged 2 commits into from Jul 27, 2022

Conversation

horochx
Copy link
Contributor

@horochx horochx commented Jul 26, 2022 •
edited

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@horochx horochx requested a review from a team as a code owner July 26, 2022 17:13
@lucasfernog
Copy link
Member

@horochx I assume this also fixes #2673 right? I'll test it tonight.

@lucasfernog
Copy link
Member

Which encoding did you use for simplified chinese? Tried a couple ones but it wasn't perfect :D

@lucasfernog
Copy link
Member

Ahh just found it in the issue, nvm.

@horochx
Copy link
Contributor Author

horochx commented Jul 27, 2022

Which encoding did you use for simplified chinese? Tried a couple ones but it wasn't perfect :D

When I use gbk, it works fine~

@lucasfernog lucasfernog merged commit d8cf9f9 into tauri-apps:dev Jul 27, 2022
@lucasfernog lucasfernog mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@horochx @lucasfernog