Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): fix relative paths in version field of tauri.config.json, closes #4723 #4725

Merged
merged 2 commits into from
Jul 24, 2022

Conversation

shniubobo
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary N/A

Other information

I decided to change the working directory, instead of resolving the relative path by joining it with the parent directory of tauri.config.json. The latter requires that tauri_utils::config::PackageVersion::deserialize know the path to tauri.config.json, which is not trivial to implement.

For more details, please refer to #4723.

@shniubobo shniubobo requested a review from a team as a code owner July 20, 2022 16:03
@lucasfernog lucasfernog merged commit accbc5e into tauri-apps:dev Jul 24, 2022
@shniubobo shniubobo deleted the issue/4723 branch July 29, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants