Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved EventEmitter for tauri api shell #4697

Merged
merged 3 commits into from Jul 25, 2022
Merged

Improved EventEmitter for tauri api shell #4697

merged 3 commits into from Jul 25, 2022

Conversation

LIMPIX31
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

I freaked out when I found out that I couldn't unsubscribe from stdout. 馃懣

@LIMPIX31 LIMPIX31 requested a review from a team as a code owner July 16, 2022 19:06
@LIMPIX31 LIMPIX31 force-pushed the tauri-api-shell-eventemitter branch from ba4273a to 9ea04dc Compare July 16, 2022 19:38
@lucasfernog lucasfernog merged commit aa9f124 into tauri-apps:dev Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LIMPIX31 @lucasfernog