Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api): remove type-fest #4605

Merged
merged 2 commits into from Jul 6, 2022
Merged

chore(api): remove type-fest #4605

merged 2 commits into from Jul 6, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: chore

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner July 6, 2022 12:30
JonasKruckenberg
JonasKruckenberg previously approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@JonasKruckenberg JonasKruckenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JonasKruckenberg
Copy link
Contributor

Just run prettier and we're good 👍

@lucasfernog lucasfernog merged commit d5e910e into dev Jul 6, 2022
@lucasfernog lucasfernog deleted the chore/remove-type-fest branch July 6, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars approved these changes

@JonasKruckenberg JonasKruckenberg JonasKruckenberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucasfernog @JonasKruckenberg @FabianLars