Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some typos #4403

Merged
merged 2 commits into from Jun 19, 2022
Merged

fix: some typos #4403

merged 2 commits into from Jun 19, 2022

Conversation

yutotnh
Copy link
Contributor

@yutotnh yutotnh commented Jun 19, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@yutotnh yutotnh requested review from a team June 19, 2022 11:52
@yutotnh yutotnh requested a review from a team as a code owner June 19, 2022 11:52
amrbashir
amrbashir previously approved these changes Jun 19, 2022
View reviewed changes
@FabianLars
Copy link
Member

FabianLars commented Jun 19, 2022 •
edited

i think we need a changefile because of the typo in the allowlist error match thingy right?

lucasfernog
lucasfernog previously approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for catching these!

@lucasfernog lucasfernog dismissed stale reviews from amrbashir and themself via d6c4246 June 19, 2022 12:20
@lucasfernog lucasfernog merged commit cbceb7d into tauri-apps:dev Jun 19, 2022
@yutotnh yutotnh deleted the fix-typo branch June 19, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@amrbashir amrbashir amrbashir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yutotnh @FabianLars @lucasfernog @amrbashir