Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: never remove ipc callback & mem never be released #4274

Merged
merged 2 commits into from Jun 5, 2022
Merged

fix: never remove ipc callback & mem never be released #4274

merged 2 commits into from Jun 5, 2022

Conversation

f91kdash
Copy link
Contributor

@f91kdash f91kdash commented Jun 5, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@f91kdash f91kdash requested a review from a team June 5, 2022 07:53
@f91kdash f91kdash requested a review from a team as a code owner June 5, 2022 12:56
@lucasfernog
Copy link
Member

Ref #4026

@lucasfernog lucasfernog mentioned this pull request Jun 5, 2022
Open
lucasfernog
lucasfernog approved these changes Jun 5, 2022
View reviewed changes
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this! ❤️

@lucasfernog lucasfernog merged commit f72cace into tauri-apps:dev Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@f91kdash @lucasfernog