Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): account for monitor position when centering window #4166

Merged
merged 1 commit into from May 21, 2022
Merged

fix(core): account for monitor position when centering window #4166

merged 1 commit into from May 21, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

See #4149 (comment)

@lucasfernog lucasfernog requested a review from a team May 18, 2022 22:26
@lucasfernog lucasfernog requested a review from a team as a code owner May 18, 2022 22:26
FabianLars
FabianLars approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Linux & Windows, with 3 displays (different resolutions, primary monitor in the middle).

@lucasfernog
Copy link
Member Author

@FabianLars do you know if this fixes #2981 ?

@FabianLars
Copy link
Member

I'd imagine so, yea. But i didn't test macos at all and can't test macos with multiple displays :/

@lucasfernog lucasfernog merged commit a7a9fde into dev May 21, 2022
@lucasfernog lucasfernog deleted the fix/window-center branch May 21, 2022 12:56
@lucasfernog lucasfernog mentioned this pull request May 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasfernog @FabianLars