Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't override default keychain, closes #4008 #4053

Merged
merged 9 commits into from May 5, 2022
Merged

fix: don't override default keychain, closes #4008 #4053

merged 9 commits into from May 5, 2022

Conversation

JonasKruckenberg
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@JonasKruckenberg JonasKruckenberg mentioned this pull request May 4, 2022
Closed
@JonasKruckenberg JonasKruckenberg marked this pull request as ready for review May 4, 2022 21:20
@JonasKruckenberg JonasKruckenberg requested a review from a team May 4, 2022 21:20
@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner May 4, 2022 21:20
lucasfernog
lucasfernog approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! ❤️

@lucasfernog lucasfernog merged commit a4fcaf1 into dev May 5, 2022
@lucasfernog lucasfernog deleted the no-default-keychain branch May 5, 2022 21:29
dceddia pushed a commit to dceddia/tauri that referenced this pull request May 14, 2022
@JonasKruckenberg @lucasfernog @dceddia
fix: don't override default keychain, closes tauri-apps#4008 (tauri-a…
74293b6 
…pps#4053)

Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonasKruckenberg @lucasfernog