Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): nested isolation iframes, closes #4015 #4020

Merged
merged 2 commits into from May 1, 2022
Merged

fix(core): nested isolation iframes, closes #4015 #4020

merged 2 commits into from May 1, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team May 1, 2022 17:12
@lucasfernog lucasfernog requested a review from a team as a code owner May 1, 2022 17:12
@lucasfernog
Copy link
Member Author

The issue happens because wry is configured to run the isolation scripts on all frames on macOS and Windows.

chippers
chippers approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@chippers chippers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me from a phone review.

@lucasfernog lucasfernog merged commit 022eed4 into dev May 1, 2022
@lucasfernog lucasfernog deleted the fix/nested-isolation-iframe branch May 1, 2022 18:50
dceddia pushed a commit to dceddia/tauri that referenced this pull request May 14, 2022
@lucasfernog @dceddia
fix(core): nested isolation iframes, closes tauri-apps#4015 (tauri-ap…
6b690ac 
…ps#4020)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chippers chippers chippers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasfernog @chippers