-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(updater): separate intel and apple silicon targets, closes #3359 #3739
Conversation
I think this solution doesn't scale well, think about windows on ARM for example. If it has to be s breaking change (which I also think it has to) then let's make it a proper 3rd parameter to the URL. |
As said on discord i agree with jonas. |
I propose we create two new variables that can optionally be present in the URL: Those variables are replaced by their equivalent While we're at it we can also consider exposing |
Looking good 👍🏻 |
core/tauri/src/app.rs
Outdated
@@ -1087,6 +1104,38 @@ impl<R: Runtime> Builder<R> { | |||
self | |||
} | |||
|
|||
/// Sets the current platform's target name for the updater. | |||
/// | |||
/// By default Tauri looks for one of `linux`, `win32`, `win64`, `darwin-silicon` or `darwin-intel` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not up to date anymore correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops didn't see this one, thanks
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information