Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(updater): separate intel and apple silicon targets, closes #3359 #3739

Merged
merged 5 commits into from Mar 23, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team March 20, 2022 02:05
@lucasfernog lucasfernog requested a review from a team as a code owner March 20, 2022 02:05
@JonasKruckenberg
Copy link
Contributor

JonasKruckenberg commented Mar 20, 2022

I think this solution doesn't scale well, think about windows on ARM for example.

If it has to be s breaking change (which I also think it has to) then let's make it a proper 3rd parameter to the URL.

@FabianLars
Copy link
Member

As said on discord i agree with jonas.
Furthermore, what about darwin universal? Ofc this can be handled server side by just providing the universal bundle no matter the arch, just wanted to make sure we think about that and (officially) set on an approach here

@JonasKruckenberg
Copy link
Contributor

I propose we create two new variables that can optionally be present in the URL: target_arch target_os.

Those variables are replaced by their equivalent cfg!(<variable>) values for predictability.

While we're at it we can also consider exposing target_feature, target_endian, target_pointer_width and debug_assertions for good measure. The former can be helpful when sidecar binaries are at play and the last for opting users into a "debug build" channel

@JonasKruckenberg
Copy link
Contributor

Looking good 👍🏻

@@ -1087,6 +1104,38 @@ impl<R: Runtime> Builder<R> {
self
}

/// Sets the current platform's target name for the updater.
///
/// By default Tauri looks for one of `linux`, `win32`, `win64`, `darwin-silicon` or `darwin-intel`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not up to date anymore correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops didn't see this one, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants