Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): return boolean on Manager::manage #3682

Merged
merged 1 commit into from Mar 13, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This is a small breaking change (only breaks code that uses .manage() return values like directly returning it on a function) but I believe we really need this for v1, we should give this information to users.

@lucasfernog lucasfernog requested a review from a team March 12, 2022 01:47
@lucasfernog lucasfernog requested a review from a team as a code owner March 12, 2022 01:47
@lucasfernog lucasfernog merged commit 263b45e into dev Mar 13, 2022
@lucasfernog lucasfernog deleted the refactor/state-management branch March 13, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant