feat(core): add WindowBuilder type #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/tauri/src/app.rs
Outdated
| /// Initializes a webview window builder with the given window label and URL to load on the webview. | ||
| /// | ||
| /// Data URLs are only supported with the `window-data-url` feature flag. | ||
| pub fn window_builder<L: Into<String>>(&self, label: L, url: WindowUrl) -> WindowBuilder<R> { |
There was a problem hiding this comment.
I know we use this exact pattern in other place too, but can we "invert" this interface?
I.e. instead of a method on AppHandle we pass AppHandle to the WindowBuilder::new constructor?
This "inline constructor" feels a bit off to me 🤔
There was a problem hiding this comment.
I agree, this is how it is in tao too.
There was a problem hiding this comment.
yeah I like that idea, i'll change that
There was a problem hiding this comment.
Maybe we can review rest of Tauri and make everything consistent?
Sure that would be a breaking change but a good one maybe 🤔
There was a problem hiding this comment.
Well that depends on the size of the refactor/breakingchange and the impact on post v1 work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
This is the first step to allow customizing the CSP #3533