use older symlink check function #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::fs::Metadata::is_symlink` was stabilized in Rust 1.58, but we don't want to bump it just for that since there is a very simple workaround (metadata -> filetype -> is_symlink).
FabianLars
previously approved these changes
Mar 1, 2022
lucasfernog
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
I meant to do this before finishing the restart PR, but I forgot.
std::fs::Metadata::is_symlinkwas stabilized in Rust 1.58, but we don't want to bump our MSRV just for that since there is a very simple workaround (metadata -> filetype -> is_symlink). I didn't actually get to test/run this myself because I made this edit from my phone.