New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): docs.rs on Windows and macOS #3566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind the __isolation-docs
workaround if ring
itself if causing cargo doc
to fail. We just will want to make sure that is what causes it. The suggested change makes it a single compile-time error if it is somehow used without enabling the isolation feature or the isolation docs workaround, along with making using it with only the docs workaround a runtime error since it's not secure.
I tested the doc generation directly using the docs.rs repo and ring was one of the issues, so i had to disable it. |
Co-authored-by: chip <chip@chip.sh>
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information