Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): docs.rs on Windows and macOS #3566

Merged
merged 15 commits into from Mar 2, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested review from a team February 27, 2022 18:41
@lucasfernog lucasfernog requested a review from a team as a code owner February 27, 2022 18:41
Copy link
Member

@chippers chippers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the __isolation-docs workaround if ring itself if causing cargo doc to fail. We just will want to make sure that is what causes it. The suggested change makes it a single compile-time error if it is somehow used without enabling the isolation feature or the isolation docs workaround, along with making using it with only the docs workaround a runtime error since it's not secure.

core/tauri-utils/src/pattern/isolation.rs Outdated Show resolved Hide resolved
@lucasfernog
Copy link
Member Author

I tested the doc generation directly using the docs.rs repo and ring was one of the issues, so i had to disable it.

@lucasfernog lucasfernog merged commit 0f15589 into tauri-apps:dev Mar 2, 2022
@lucasfernog lucasfernog deleted the fix/docs branch March 2, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants