Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): enhance HTTP scope glob validation, closes #3507 #3515

Merged
merged 1 commit into from Feb 24, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested review from a team February 19, 2022 19:50
@lucasfernog lucasfernog requested a review from a team as a code owner February 19, 2022 19:50
@lucasfernog lucasfernog merged commit 944b124 into dev Feb 24, 2022
@lucasfernog lucasfernog deleted the feat/scope-http-glob branch February 24, 2022 13:06
@peterroe
Copy link

peterroe commented Apr 5, 2022

hello, I meet a error because of glob match.

example:

"http": {
        "all": true,
        "request": true,
        "scope": ["https://**","http://**"]
},

I found that the above can only match the first-level route,such as https://xxx.xxx/xxx

it can't match the second-level route, such as https://xxx.xxx/xxx/xxx or https://xxx.xxx/xxx/xxx/xxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants