Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove non-existent cargo rerun check #3412

Merged
merged 2 commits into from
Feb 12, 2022
Merged

Conversation

chippers
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This was the cause of projects always rebuilding, when a target file doesn't exist it seems cargo will default to always rebuild.

@chippers chippers requested a review from a team February 12, 2022 00:14
@chippers chippers requested a review from a team as a code owner February 12, 2022 00:14
@lucasfernog lucasfernog merged commit 65287cd into dev Feb 12, 2022
@lucasfernog lucasfernog deleted the fix/always-rebuilding branch February 12, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants