Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli.rs): app path resolution on projects without git, closes #3409 #3410

Merged
merged 2 commits into from Feb 11, 2022
Merged

fix(cli.rs): app path resolution on projects without git, closes #3409 #3410

merged 2 commits into from Feb 11, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team February 11, 2022 21:45
@lucasfernog lucasfernog requested a review from a team as a code owner February 11, 2022 21:45
FabianLars
FabianLars approved these changes Feb 11, 2022
View reviewed changes
Copy link
Sponsor Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That really was an emotional rollercoaster 😂

@lucasfernog
Copy link
Member Author

Got me so mad I even started trying to make jokes. Anyway, another release coming up.

@lucasfernog
Copy link
Member Author

Thanks for fixing it btw @FabianLars I wouldn't find the gitignore problem lol

@lucasfernog lucasfernog merged commit d8acbe1 into dev Feb 11, 2022
@lucasfernog lucasfernog deleted the fix/app-path-resolver branch February 11, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasfernog @FabianLars