Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): expose functions to serialize serde::Serialize values to JS #3354

Merged
merged 5 commits into from Feb 7, 2022
Merged

feat(core): expose functions to serialize serde::Serialize values to JS #3354

merged 5 commits into from Feb 7, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner February 7, 2022 18:15
@lucasfernog lucasfernog requested a review from a team February 7, 2022 18:15
@lucasfernog
Copy link
Member Author

This functionality is currently copy-pasted on some of our plugins, and is also helpful to any userland app using window.eval passing serde::Serialize values.

@lucasfernog lucasfernog changed the title feat(core): expose api::ipc::format_json_parse feat(core): expose api::ipc::format_json Feb 7, 2022
@lucasfernog lucasfernog changed the title feat(core): expose api::ipc::format_json feat(core): expose functions to serialize serde::Serialize values to JS Feb 7, 2022
@lucasfernog lucasfernog merged commit 5a94200 into next Feb 7, 2022
@lucasfernog lucasfernog deleted the feat/expose-ipc-format branch February 7, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lucasfernog