Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): window-specific event delivery, closes #3302 #3344

Merged
merged 2 commits into from Feb 6, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner February 6, 2022 17:38
@lucasfernog lucasfernog requested review from a team February 6, 2022 17:38
}

fn validate_label(label: &str) {
pub fn is_label_valid(label: &str) -> bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It should be is_valid_label() to match assert_valid_label()

@lucasfernog
Copy link
Member Author

Any help testing this would be very welcome. I did some tests using the API example and the multiwindow example and it looks correct, but there might be other use cases that I didn't cover. I'll merge this so it can get more visibility.
Note that you need the next branch @tauri-apps/api package, so you'd need to clone the repo, cd tooling/api && yarn && yarn build && yarn link and yarn link it on your project.

@FabianLars
Copy link
Member

FabianLars commented Feb 6, 2022

I did some tests earlier and it seemed to work well in regard to the linked issue.
I also tried to test for unwanted side effects and didn't find any, but that's something you can't really be a 100% sure about, so take that with a grain of salt.

Edit: So yes, more people doing their own testing is indeed a good idea 🙏

@lucasfernog
Copy link
Member Author

Thanks Fabian. Good thing we still have time to make tests and get feedback from the community (specially until the stable release) to get this working perfectly :P

@lucasfernog lucasfernog merged commit 9b34055 into next Feb 6, 2022
@lucasfernog lucasfernog deleted the fix/window-specific-event branch February 6, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants