-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose event interface. fixes #2733 #3321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to fix this.
You need to:
- rename
EmittedEvent
toEvent
and remove any mention ofEmittedEvent
- rename
Event
toRunEvent
, obviously this will clash with theruntime::RunEvent
import incore/tauri/src/app.rs
so you're just gonna need to rename the import and not the original struct, something like thisuse runtime::RunEvent as RuntimeRunEvent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add a changefil in .changes
folder and don't forget to mention the breaking change Event
-> RunEvent
What would be the appropriate level for this change? Semver would dictate to use major since the API is changed, but semver doesn't seem to be enforced for |
It's not enforced because of the prelease stuff, so patch is fine, as this needs to land in v1 anyway (mainly because of the EventHandler fix) |
There seems to be a change request pending, but I can't figure out, what it is referring to. @amrbashir your name appears in the UI, have I overlooked something? |
@Chaostheorie Don't worry, that's just the UI not updating until he approves the PR. As far as i can see you got everything he requested so far 👍 |
@amrbashir and @FabianLars thank you for the great help and explanations. |
Expose
tauri::event
and renametauri::event::Event
toEmittedEvent
. Temporary fix for #2733. This is supposed to be a POC for my internal use until #2733 is resolved in v1.x.What kind of change does this PR introduce?
Does this PR introduce a breaking change?