New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api.js) Replace number[]
with Uint8Array
. fixes #3306
#3305
Conversation
number[]
with Uint8Array
number[]
with Uint8Array
number[]
with Uint8Array
number[]
with Uint8Array
. fixes #3306
if we merge this we need a changefile too :P |
Throwback to the time I merged a PR and deleted the branch without a changefile and had to open a super embarrassing PR with only a changefile 😂 Edit:
After your comment on the issue, I feel like making this a patch thing is good enough 🤔 Edit2: Not that it matters much, this will result in a major release anyway lol |
yeah we did |
number[]
with Uint8Array
. fixes #3306number[]
with Uint8Array
. fixes #3306
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
attacked issue #3306
Checklist
fix #___, #___
)Other information