Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api.js) Replace number[]with Uint8Array. fixes #3306 #3305

Merged
merged 9 commits into from Feb 5, 2022

Conversation

JonasKruckenberg
Copy link
Contributor

@JonasKruckenberg JonasKruckenberg commented Jan 29, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

attacked issue #3306

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@JonasKruckenberg JonasKruckenberg requested a review from a team January 29, 2022 10:51
@JonasKruckenberg JonasKruckenberg changed the title refactor(api): Replace number[]with Uint8Array fix #3306 Replace number[]with Uint8Array Jan 29, 2022
@JonasKruckenberg JonasKruckenberg changed the title fix #3306 Replace number[]with Uint8Array Replace number[]with Uint8Array. fixes #3306 Jan 29, 2022
@FabianLars
Copy link
Member

if we merge this we need a changefile too :P
ngl, i'm glad i'm not the only one who always forgets them 😂

@JonasKruckenberg
Copy link
Contributor Author

JonasKruckenberg commented Jan 29, 2022

ngl, i'm glad i'm not the only one who always forgets them 😂

Throwback to the time I merged a PR and deleted the branch without a changefile and had to open a super embarrassing PR with only a changefile 😂

Edit:

if we merge this we need a changefile too :P

After your comment on the issue, I feel like making this a patch thing is good enough 🤔

Edit2: Not that it matters much, this will result in a major release anyway lol

@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner January 29, 2022 12:15
@FabianLars
Copy link
Member

yeah we did patch all the time, for pretty much every change. Really doesn't seem to matter for pre-releases, or at least from 0.x to 1.0-pre, whatever.

@JonasKruckenberg JonasKruckenberg changed the title Replace number[]with Uint8Array. fixes #3306 fix(api.js) Replace number[]with Uint8Array. fixes #3306 Jan 29, 2022
tooling/api/src/http.ts Show resolved Hide resolved
tooling/api/src/fs.ts Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 9b19a80 into next Feb 5, 2022
@lucasfernog lucasfernog deleted the JonasKruckenberg-patch-1 branch February 5, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants