Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundler): Use arch instead of llvm_target. fix #3285 #3286

Merged
merged 6 commits into from Feb 5, 2022
Merged

fix(bundler): Use arch instead of llvm_target. fix #3285 #3286

merged 6 commits into from Feb 5, 2022

Conversation

JonasKruckenberg
Copy link
Contributor

The llvm target misidentified the arch on apple silicon, causing sidecar bundling to fail.
This fixes #3285.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@JonasKruckenberg
fix(bundler): Use arch instead of llvm_target
fbbb217 
The llvm target misidentified the arch on apple silicon, causing sidecar bundling to fail.
This fixes #3285.
@JonasKruckenberg JonasKruckenberg requested a review from a team January 26, 2022 10:52
@lucasfernog
Copy link
Member

I see you didn't change the command to rustc --print cfg as stated on the issue. Is that intentional?

@JonasKruckenberg
Copy link
Contributor Author

I see you didn't change the command to rustc --print cfg as stated on the issue. Is that intentional?

nope, just didn't get to it yet bc the parsing is a bit more involved

@JonasKruckenberg
fix: Use rustc --print cfg for target arch
d74625b 
Replaces the nightly (and undocumented?) `RUSTC_BOOTSTRAP=1 rustc -Z unstable-options --print target-spec-json` with `rustc --print cfg` which is on the public interface, documented and fully uses stable rust
@JonasKruckenberg JonasKruckenberg requested a review from a team January 29, 2022 12:52
@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner January 29, 2022 12:54
@lucasfernog lucasfernog merged commit 839daec into next Feb 5, 2022
@lucasfernog lucasfernog deleted the fix/incorrect-llvm-target branch February 5, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Incorrect llvm target
2 participants
@JonasKruckenberg @lucasfernog