Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent event name usage #3228

Merged
merged 2 commits into from Jan 15, 2022
Merged

Consistent event name usage #3228

merged 2 commits into from Jan 15, 2022

Conversation

JonasKruckenberg
Copy link
Contributor

Makes the Event interface use the EventName type for the event field instea of string

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

https://discord.com/channels/616186924390023171/731495028677148753/931986520871690331

@JonasKruckenberg
fix(api.js) use EventName consistently
29317c1 
Makes the `Event` interface use the `EventName` type for the `event` field instea of `string`
@JonasKruckenberg
add changeset
a4198cf
@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner January 15, 2022 19:16
@JonasKruckenberg JonasKruckenberg requested a review from a team January 15, 2022 19:16
@JonasKruckenberg JonasKruckenberg added the scope: api.js The @tauri-apps/api npm package label Jan 15, 2022
@lucasfernog lucasfernog merged commit b5d9bcb into next Jan 15, 2022
@lucasfernog lucasfernog deleted the consistent-event-name-usage branch January 15, 2022 20:47
@JonasKruckenberg
Copy link
Contributor Author

Is the failing build on windows already know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
scope: api.js The @tauri-apps/api npm package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonasKruckenberg @lucasfernog @FabianLars