Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: plugin::Builder closes #2959 #3005

Merged
merged 10 commits into from Feb 7, 2022
Merged

feat: plugin::Builder closes #2959 #3005

merged 10 commits into from Feb 7, 2022

Conversation

JonasKruckenberg
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
    see [Proposal]: Plugin Builder #2959

Other information:

@JonasKruckenberg JonasKruckenberg requested a review from a team as a code owner December 1, 2021 11:48
@JonasKruckenberg JonasKruckenberg requested a review from a team December 1, 2021 11:48
amrbashir
amrbashir requested changes Dec 2, 2021
View reviewed changes
core/tauri/src/plugin.rs Outdated Show resolved Hide resolved
core/tauri/src/plugin.rs Outdated Show resolved Hide resolved
docs/usage/guides/plugin-builder.md Outdated Show resolved Hide resolved
docs/usage/guides/plugin-builder.md Outdated Show resolved Hide resolved
docs/usage/guides/plugin-builder.md Outdated Show resolved Hide resolved
docs/usage/guides/plugin-builder.md Outdated Show resolved Hide resolved
docs/usage/guides/plugin-builder.md Outdated Show resolved Hide resolved
JonasKruckenberg and others added 4 commits December 2, 2021 12:51
@JonasKruckenberg @amrbashir
Update doc comment
e1bc4c8 
Co-authored-by: Amr Bashir <48618675+amrbashir@users.noreply.github.com>
@JonasKruckenberg @amrbashir
Apply suggestions
338e0ab 
Co-authored-by: Amr Bashir <48618675+amrbashir@users.noreply.github.com>
@JonasKruckenberg
combine docs and add distribution section
578323a
@JonasKruckenberg
rename initialization_script to js_init_script
eb5348b
@JonasKruckenberg
Copy link
Contributor Author

JonasKruckenberg commented Dec 11, 2021 •
edited

@lucasfernog Idk why the checks have failed, but this PR is good for merging regardless

@amrbashir amrbashir added the scope: core Core packages of Tauri label Jan 1, 2022
@lucasfernog lucasfernog merged commit 9aed299 into next Feb 7, 2022
@lucasfernog lucasfernog deleted the feat/plugin-builder branch February 7, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
scope: core Core packages of Tauri
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonasKruckenberg @amrbashir @lucasfernog