fix(core): enable CORS on the asset protocol, closes #2965
#2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Must be merged after #2973. |
Comment on lines
+306
to
+316
| let window_url = Url::parse(&pending.url).unwrap(); | ||
| let window_origin = format!( | ||
| "{}://{}{}", | ||
| window_url.scheme(), | ||
| window_url.host().unwrap(), | ||
| if let Some(port) = window_url.port() { | ||
| format!(":{}", port) | ||
| } else { | ||
| "".into() | ||
| } | ||
| ); |
There was a problem hiding this comment.
This works as expected running yarn tauri build, but doesn't work when running yarn tauri dev. Same CORS error is displayed on the screen. Don't know how to fix, but my guess is that it is not registering http://localhost:3000 from the vite dev command. I have changed the allowed origin line in my fork to "*" and it works correctly without CORS error.
https://github.com/antoniotorres/tauri/blob/fix/asset-protocol-cors/core/tauri/src/manager.rs#L307
There was a problem hiding this comment.
ooops i didn't realize i was reassign the url after defining the window origin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: